More clarifications around channel_announcement handling
#1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up of lightning#1215, where we keep reworking the announcement requirements. We remove the rationale around deferring after `channel_ready` since that has been changed years ago and shouldn't be an issue anymore. We slightly rework the wording to minimize future conflicts with the splicing PR. While nodes are free to send `announcement_signatures` whenever they feel that the channel is safe from reorg, we disallow broadcasting the `channel_announcement` before at least 6 confirmations: this gives nodes a simple heuristic to ignore `channel_announcement`s for remote channels that aren't spec-compliant, without having to deal with the extra cost of managing reorgs.
tnull
reviewed
Jan 16, 2025
This was referenced Jan 16, 2025
- remove conflicting `announcement_signatures` requirements - allow a buffer of a few blocks to account for late block arrival
yyforyongyu
reviewed
Jan 16, 2025
We don't need more than 6 confirmations, we need at least that.
23 tasks
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #1215, where we keep reworking the announcement requirements.
We remove the rationale around deferring after
channel_readysince that has been changed years ago and shouldn't be an issue anymore.We slightly rework the wording to minimize future conflicts with the splicing PR.
While nodes are free to send
announcement_signatureswhenever they feel that the channel is safe from reorg, we disallow broadcasting thechannel_announcementbefore at least 6 confirmations: this gives nodes a simple heuristic to ignorechannel_announcements for remote channels that aren't spec-compliant, without having to deal with the extra cost of managing reorgs.