Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bolt 1: Missing version number in message format? #63

Closed
jeroenvanagt opened this issue Dec 18, 2016 · 2 comments
Closed

Bolt 1: Missing version number in message format? #63

jeroenvanagt opened this issue Dec 18, 2016 · 2 comments

Comments

@jeroenvanagt
Copy link

For future upgradability and backwards compatibility would it not be wise to include a version number in the message format? I know there is a type field, but it makes sense to have them both otherwise you will run out of types fields quickly (in the future).

@cdecker
Copy link
Collaborator

cdecker commented Dec 19, 2016

Well, we have a number of extension mechanisms at our disposal, the type mechanism being one. type offers us up to 65k updates. In addition we have the localfeatures and globalfeatures fields which allow a much more fine-grained signaling mechanism than a single version field. Finally, we also have the ignore trailing data mechanism, which allows us to stuff additional fields at the end of a message and have it ignored by nodes that do not support it.

Should we ever run out of options to extend the protocol we can still make a protocol upgrade by sending a protocol upgrade message and then using the new and improved version 😉

@rustyrussell
Copy link
Collaborator

rustyrussell commented Dec 20, 2016 via email

cdecker added a commit to cdecker/lightning-rfc that referenced this issue Dec 22, 2016
ASCII character set seems apropriate, since it acts a lowest common
denominator, and who'd stuff emojis in an error message anyway?

Fixes lightning#63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants