-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bolt 1: Missing version number in message format? #63
Comments
Well, we have a number of extension mechanisms at our disposal, the Should we ever run out of options to extend the protocol we can still make a protocol upgrade by sending a protocol upgrade message and then using the new and improved version 😉 |
Jeroen van Agt <[email protected]> writes:
For future upgradability and backwards compatibility would it not be
wise to include a version number in the message format? I know there
is a type field, but it makes sense to have them both otherwise you
will run out of types fields quickly (in the future).
Version numbers are a very limited way of attempting compatibility. We
use version bits, in effect. To quote BOLT #1:
Once authentication is complete, the first message reveals the
features supported or required by this node. Odd features are
optional, even features are compulsory (_it's OK to be odd_). The
meaning of these bits will be defined in the future.
1. type: 16 (`init`)
2. data:
* [2:gflen]
* [gflen:globalfeatures]
* [2:lflen]
* [lflen:localfeatures]
Hope that helps!
Rusty.
|
ASCII character set seems apropriate, since it acts a lowest common denominator, and who'd stuff emojis in an error message anyway? Fixes lightning#63
For future upgradability and backwards compatibility would it not be wise to include a version number in the message format? I know there is a type field, but it makes sense to have them both otherwise you will run out of types fields quickly (in the future).
The text was updated successfully, but these errors were encountered: