Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use golangci-lint on ci #36

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use golangci-lint on ci #36

wants to merge 4 commits into from

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Sep 3, 2024

I added this to catch lint errors with #33 but I saw it hasn't been run as the workflow wasn't approved. So maybe the existing ones already catch them. I think the linter situation is pretty good in geth so up to you.

@s1na
Copy link
Contributor Author

s1na commented Sep 3, 2024

I don't get this error:

# github.com/golang/protobuf/protoc-gen-go/descriptor
Error: ../../../go/pkg/mod/github.com/golang/[email protected]/protoc-gen-go/descriptor/descriptor.pb.go:106:61: undefined: descriptorpb.Default_FileOptions_PhpGenericServices
make: *** [Makefile:9: buildgeth] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s1na