Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-parser-combinators to 2.0.0 #300

Merged

Conversation

scala-steward
Copy link
Contributor

Updates org.scala-lang.modules:scala-parser-combinators from 1.1.2 to 2.0.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-parser-combinators" } ]

labels: library-update, semver-major

@mkurz
Copy link
Contributor

mkurz commented Jul 12, 2021

@SethTisue The scala-parser-combinators release notes state:

Note that we decided to call this 2.0.0 rather than 1.2.0, because it is not binary compatible with the 1.x series.

If we upgrade the lib in ssl-config, can the next release be v0.4.4 or should we switch to v0.5.0? WDYT?

@SethTisue
Copy link
Member

I'm not actually sure how people handle that, so this isn't some kind of authoritative opinion, but yeah, going to v0.5.0 seems appropriate to me.

@ignasi35
Copy link
Contributor

the build is broken on JDK8. It looks like there's a test that uses a hashing or encryption algorithm that's not available on JDK8

@SethTisue SethTisue self-assigned this Jul 22, 2021
@SethTisue SethTisue force-pushed the update/scala-parser-combinators-2.0.0 branch from 6c09bf7 to 1e451e3 Compare July 23, 2021 17:11
@SethTisue SethTisue force-pushed the update/scala-parser-combinators-2.0.0 branch from 1e451e3 to 8a74c2d Compare July 23, 2021 17:47
@SethTisue SethTisue merged commit 5542ee0 into lightbend:main Jul 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants