Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Remove the pecoff4j exclusion #38

Merged
merged 2 commits into from
May 21, 2018
Merged

Remove the pecoff4j exclusion #38

merged 2 commits into from
May 21, 2018

Conversation

TimMoore
Copy link

Whitesource no longer depends on this unavailable artifact, instead publishing it to Maven Central under their own group ID:

http://repo1.maven.org/maven2/org/whitesource/pecoff4j/0.0.2.1/

Whitesource no longer depends on this unavailable artifact, instead
publishing it to Maven Central under their own group ID:
http://repo1.maven.org/maven2/org/whitesource/pecoff4j/0.0.2.1/
@TimMoore
Copy link
Author

It would be great to have a new release of the plugin after this is merged. Despite the exclusion, I currently get lots of warnings in IDEA related to org.boris:pecoff4j when importing the project and it seems to slow down the imports quite a bit as it searches all of the repositories for this artifact.

#37 (implicitly) removes the transitive dependency, this change is just some further cleanup.

build.sbt Outdated
@@ -37,8 +37,8 @@ val whitesourceVersion = "2.6.9"

libraryDependencies += "org.whitesource" % "wss-agent-api" % whitesourceVersion
// Exclude pecoff library which is not on maven central and used only for .Net
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! Thanks!

@2m
Copy link

2m commented May 21, 2018

Indeed, since whitesource 2.6.0, artifacts depends on pecoff4j published under their own group id.

@dwijnand dwijnand merged commit d5338cf into lightbend:master May 21, 2018
@dwijnand
Copy link
Member

Thanks Tim and Martynas!

@dwijnand
Copy link
Member

I'll cut a release of this today.

@TimMoore TimMoore deleted the remove-pecoff4j-exclusion branch May 21, 2018 07:11
@dwijnand
Copy link
Member

https://github.com/lightbend/sbt-whitesource/releases/tag/v0.1.11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants