Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all the module graphs in the plugin and query that from the directive #9

Closed
2m opened this issue Nov 22, 2018 · 1 comment
Closed
Milestone

Comments

@2m
Copy link
Contributor

2m commented Nov 22, 2018

Current implementation is not safe, as it runs sbt task outside of the graph.

From @dwijnand

@2m whats wrong with depending on?
I mean you depend on, just via the unsafe way
I think what you might want to do is collect all the module graphs in the whole build
you can do that with sbt's ScopeFilter and .all API
and then in `DependenciesDirective` look that moduleName
that would be safe
`paradoxDirectives` is a task key so that's good
yeah, that's how to do it
@dwijnand
Copy link
Member

@ennru ennru closed this as completed in #10 Jan 15, 2019
ennru pushed a commit that referenced this issue Jan 15, 2019
…ive (#10)

One downside is that it now requires to populate `paradoxDependenciesModules` on the use side. But on the other hand, the access to the dependency tree is now done without touching the state directly.

Fixes #9
@ennru ennru added this to the v0.2 milestone Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants