Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse signatures to avoid false positives #505

Merged
merged 1 commit into from
May 25, 2020
Merged

Parse signatures to avoid false positives #505

merged 1 commit into from
May 25, 2020

Conversation

raboof
Copy link
Contributor

@raboof raboof commented May 22, 2020

Avoids false positive when only the names are changed

Fixes the 'rename' (but not 'reorder') part of #363

@dwijnand
Copy link
Collaborator 

[error] mima-core: Failed binary compatibility check against com.typesafe:mima-core_2.12:0.7.0! Found 1 potential problems (filtered 25)
[error]  * method hasMatchingCtorSig(java.lang.String,java.lang.String)Boolean in object com.typesafe.tools.mima.lib.analyze.method.MethodChecker does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("com.typesafe.tools.mima.lib.analyze.method.MethodChecker.hasMatchingCtorSig")

Very nice!

We might want to move this modeling and parsing logic outside of MethodChecker, which can happen before or after merging.

@raboof
Parse signatures to avoid false positives
a74cbff 
Avoids false positive when only the names are changed
@raboof raboof force-pushed the compare-signature-independent-of-name branch from f4c0f09 to a74cbff Compare May 25, 2020 11:42
@raboof raboof merged commit f417373 into lightbend-labs:master May 25, 2020
@raboof raboof mentioned this pull request May 25, 2020
Merged
This was referenced Jun 3, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raboof @dwijnand