Make server codegen more deterministic by ensuring service methods ordering #988 #992
Conversation
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
|
Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged. For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask! |
|
refs #988 |
charlietsai
force-pushed
the
deterministic-server-codegen
branch
from
8c378fe to
277ed2c
Compare
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
charlietsai
force-pushed
the
deterministic-server-codegen
branch
from
277ed2c to
d4bb438
Compare
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
|
sorry for the noise, had to fix my author/comitter information |
|
OK TO TEST |
No problem, verified the CLA is now OK (even though the validator hasn't updated yet) |
|
awesome, thanks for the quick turnaround! |
|
Sure, thanks for the improvement! |
From what I could tell, the
.toSettransformations related toService.methodswere done to remove duplicates. Changing to aSeqvia.distinctto ensure the ordering is deterministic.Tests continue to pass with
sbt test.Also checked the example produced by
and they look consistent with what was generated before.