Cut dependency on scala-compiler and scala-reflect #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
approved these changes
Apr 28, 2020
|
Well, I wasn't running the (stupidly slow) scripted tests. Serves me right: |
MiMa has historically depended on scala-compiler, without fully cross-building too(!) making it a bit of risk - see DeprecatedPathApis as an example. However, it only uses: * classpath things * Settings, to make classpaths (& log levels but not really) * ClassfileConstants, which are part of the Java spec anyways * scala-reflect's AbstractFile, as a part of ClassPath's API MiMa also uses `scala.reflect.NameTransformer`, but that turns out to actually be in scala-library. :-O So I made subset copies of AbstractFile (AbsFile), ClassPath and ClassfileConstants, making use of java.nio instead of java.io.File and java.util.zip. Turns out there are classpath things available in and around `javax.tools.JavaCompiler`, but I'll leave that for a second pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MiMa has historically depended on scala-compiler, without fully
cross-building too(!) making it a bit of risk - see DeprecatedPathApis
as an example. However, it only uses:
MiMa also uses
scala.reflect.NameTransformer, but that turns out toactually be in scala-library. :-O
So I made subset copies of AbstractFile (AbsFile), ClassPath and
ClassfileConstants, making use of java.nio instead of java.io.File and
java.util.zip.
Turns out there are classpath things available in and around
javax.tools.JavaCompiler, but I'll leave that for a second pass.Fixes #193, btw. Not that it's open...