Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with dependency on scala.tools.nsc code #193

Closed
dwijnand opened this issue Aug 1, 2017 · 5 comments · Fixed by scala/community-build#926 or #495
Closed

Deal with dependency on scala.tools.nsc code #193

dwijnand opened this issue Aug 1, 2017 · 5 comments · Fixed by scala/community-build#926 or #495

Comments

@dwijnand
Copy link
Collaborator

dwijnand commented Aug 1, 2017

Breaking off from #191 the long term enhancements.

scala.tools.nsc doesn't guarantee backwards binary compatibility. So we can either:

  • Rewrite the parts of MiMa that depend on scala.tools.nsc, or
  • Consider fully cross-building MiMa.
@dwijnand
Copy link
Collaborator Author

dwijnand commented Nov 9, 2018

Fully cross-building is probably an option, given this is mostly consumed via the sbt plugin.

With a minor bump, so it's a little easier to remember.

@dwijnand dwijnand reopened this Nov 9, 2018
@dwijnand
Copy link
Collaborator Author

dwijnand commented Nov 9, 2018

Oh, this would mean fresh MiMA releases for every Scala release...

Hmm. @SethTisue, worth it? Can this be part of the Scala release procedure?

@SethTisue
Copy link
Collaborator

SethTisue commented Jun 13, 2019

I think that for a new Scala minor release to break MiMa is a fairly unusual occurrence. If and when it happens, we can just roll a new MiMa release at that point, that seems sufficient to me.

@dwijnand
Copy link
Collaborator Author

Reverted: scala/community-build@5816cdb

@dwijnand dwijnand reopened this Jun 18, 2019
@dwijnand
Copy link
Collaborator Author

Too hard. Hopefully, we don't shoot ourselves in the foot. And if we do we'll have good reason to smash this back open and fix it properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants