Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiMa does not like jars with a module-info.class #206

Closed
schmitch opened this issue Apr 26, 2018 · 4 comments
Closed

MiMa does not like jars with a module-info.class #206

schmitch opened this issue Apr 26, 2018 · 4 comments
Assignees
@dwijnand
Milestone
0.3.0

Comments

@schmitch
Copy link

schmitch commented Apr 26, 2018 •
edited
Loading

Currently when adding jaxb-api.jar to a project with MiMa enabled, MiMa can't analyze Binary Incompatible changes.

When adding it to Play I get the following error:
java.lang.RuntimeException: bad constant pool tag 19 at byte 54

The problem is that this jar contains a module-info.class which basically just gets ignored by java8/scala/sbt. However MiMa still tries to analyze it and will fail with the Exception.
@schmitch schmitch changed the title MiMa does not like jaxb-api.jar/Multi-Release JAR MiMa does not like jars with a module-info.jar Apr 26, 2018
@schmitch schmitch changed the title MiMa does not like jars with a module-info.jar MiMa does not like jars with a module-info.class Apr 26, 2018
@2m
Copy link
Contributor

2m commented Apr 27, 2018

Yup. Ignoring module-info.class sounds like a good solution.

@schmitch schmitch mentioned this issue Apr 27, 2018
Merged
@2m
Copy link
Contributor

2m commented Apr 27, 2018

What is more, MiMa does not usually check BC of the dependencies. Therefore it should not fail if a dependency has something that it can not parse.

@dwijnand dwijnand mentioned this issue Apr 30, 2018
Merged
@dwijnand dwijnand self-assigned this Apr 30, 2018
@dwijnand dwijnand added this to the 0.2.1 milestone May 12, 2018
@schmitch
Copy link
Author

is there a timeframe for 0.2.1?

@dwijnand
Copy link
Collaborator

I'm at Scala Days Berlin, so I'll try and get it out next week.

jeffmay added a commit to rallyhealth/play-module-json-error-handler that referenced this issue Sep 28, 2018
@jeffmay
Upgrade to sbt 1.0 and fix issues with MiMa versioning
344596d 
- Upgrade to sbt 1.0 to solve a weird bug with MiMa
  (lightbend-labs/mima#206)
- Add missing resolver
- Remove name supression config
- Fix resolver issue
@jeffmay jeffmay mentioned this issue Sep 28, 2018
Merged
jeffmay added a commit to rallyhealth/play-module-json-error-handler that referenced this issue Sep 28, 2018
@jeffmay
Upgrade to sbt 1.0 and fix issues with MiMa versioning
d18a66f 
- Upgrade to sbt 1.0 to solve a weird bug with MiMa
  (lightbend-labs/mima#206)
- Add missing resolver
- Remove name supression config
- Fix resolver issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwijnand dwijnand

Labels
None yet
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@dwijnand @2m @schmitch