-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make MiMa aware of @akka.annotation.ApiMayChange / @akka.annotation.InternalApi #160
Comments
I think it would be best to provide such a feature by enhancing MiMa's ProblemFilters: |
|
Yeah. (maybe more simply |
Yeah, would be very cool :) I may hack on this... Would save us a lot of explaining to contributors who touch these classes. |
This is midly related to #53 |
I'm thinking we can do this by name. Probably best to stick to fully qualified name. But then I just realised it can a user-definable list of names, e.g. Scala 3's new |
Note that #647 only implements this for Scala 3, not for Scala 2. (Because anything involving unpickling must be separately implemented, since Scala 3's pickle format is completely different, being TASTy-based.) |
We introduced a few annotations to mark that a given type should not matter when checking bin-compat:
@ApiMayChange
- API still not quite stable, will change@InternalAPI
- internal API, can change however it wants to@DoNotInherit
- no one except the same library which provides this class should extend this classFull types: https://github.com/akka/akka/pull/22110/files
Example usage: akka/akka#22109
MiMa could check if a type has annotations and if the name matches these then it can ignore warnings about a given type or method.
The text was updated successfully, but these errors were encountered: