Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpickle annotations to ignore "exclude annotations" (on Scala 3) #647

Merged
merged 11 commits into from
Aug 23, 2021
Merged

Unpickle annotations to ignore "exclude annotations" (on Scala 3) #647

merged 11 commits into from
Aug 23, 2021

Conversation

dwijnand
Copy link
Collaborator

@dwijnand dwijnand commented Aug 2, 2021 •
edited
Loading

For example @scala.annotation.experimental or @akka.annotation.ApiMayChange / @akka.annotation.InternalApi.

Blocker for releasing (but not necessarily for merging):

  • ignore @experimental on methods, at least for Scala 3

Blocker for closing #160:

  • allow the annotation to be configured

@dwijnand dwijnand linked an issue Aug 2, 2021 that may be closed by this pull request
Make MiMa aware of @akka.annotation.ApiMayChange / @akka.annotation.InternalApi #160
Closed
@dwijnand dwijnand force-pushed the ignore-experimental branch from 042b951 to 273c675 Compare August 2, 2021 14:05
@dwijnand dwijnand force-pushed the ignore-experimental branch 5 times, most recently from 34012a9 to 1137c4d Compare August 20, 2021 21:48
@dwijnand dwijnand force-pushed the ignore-experimental branch from 1137c4d to ed93586 Compare August 21, 2021 08:58
@dwijnand dwijnand removed a link to an issue Aug 21, 2021
Make MiMa aware of @akka.annotation.ApiMayChange / @akka.annotation.InternalApi #160
Closed
@dwijnand dwijnand force-pushed the ignore-experimental branch from 4f61cd0 to c07c83a Compare August 22, 2021 01:50
@dwijnand dwijnand force-pushed the ignore-experimental branch from c07c83a to fa2a456 Compare August 22, 2021 02:01
@dwijnand
Extending @experimental tests+impl
ef4615d 
I wanted to make sure `@annotation.experimental` worked, turns out it
already did, but adding to an existing test made me realise I need to
handle SHAREDtype.
@dwijnand
Move printClassNames to TastyPrinter
86331f2
@dwijnand
Always TASTy unpickle!
0750167
@dwijnand
Setup to ignore new experimental methods too
b19ae44
@dwijnand
Handle experimental nested classes (and their methods)
d09144d
@dwijnand dwijnand force-pushed the ignore-experimental branch from 948a53a to d09144d Compare August 23, 2021 13:34
@dwijnand dwijnand linked an issue Aug 23, 2021 that may be closed by this pull request
Make MiMa aware of @akka.annotation.ApiMayChange / @akka.annotation.InternalApi #160
Closed
@dwijnand dwijnand changed the title Unpickle annotations to ignore @experimental Unpickle annotations to ignore "exclude annotations" Aug 23, 2021
@dwijnand dwijnand force-pushed the ignore-experimental branch from 8dc9587 to 8a6fc57 Compare August 23, 2021 18:46
@dwijnand dwijnand added this to the 1.0.0 milestone Aug 23, 2021
@dwijnand dwijnand merged commit b20f56d into lightbend-labs:main Aug 23, 2021
@dwijnand dwijnand deleted the ignore-experimental branch August 23, 2021 19:08
@SethTisue SethTisue mentioned this pull request Aug 2, 2022
Closed
@SethTisue SethTisue mentioned this pull request Aug 2, 2022
Merged
@SethTisue SethTisue changed the title Unpickle annotations to ignore "exclude annotations" Unpickle annotations to ignore "exclude annotations" (on Scala 3) Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Make MiMa aware of @akka.annotation.ApiMayChange / @akka.annotation.InternalApi
1 participant
@dwijnand