Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary array #731

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

hkupty
Copy link
Contributor

@hkupty hkupty commented May 18, 2021

Usage of this array seems to have been dropped by #280, but the array
remained.

Cleaning up so it doesn't allocate the array needlessly anymore.

Fixes #730.

Copy link
Collaborator

@havocp havocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hkupty
Copy link
Contributor Author

hkupty commented May 18, 2021

Glad to help!

@hkupty
Copy link
Contributor Author

hkupty commented May 18, 2021

Accepted CLA

Usage of this array seems to have been dropped by lightbend#280, but the array
remained.

Cleaning up so it doesn't allocate the array needlessly anymore.

Fixes lightbend#730.
@hkupty hkupty force-pushed the drop-array-from-fast-path branch from 5a4bb04 to fca5de9 Compare May 21, 2021 21:23
@hkupty
Copy link
Contributor Author

hkupty commented May 21, 2021

I force-pushed the commit again to trigger CI and release the cla-validator that was stuck.

@hkupty
Copy link
Contributor Author

hkupty commented May 28, 2021

Hey, is it missing anything to be merged?

@havocp havocp merged commit 2c0ac85 into lightbend:main May 28, 2021
@hkupty hkupty deleted the drop-array-from-fast-path branch May 28, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PathParser.fastPathBuild array allocation seems to do nothing
2 participants