Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish with stable JDK9 module name #546

Closed
jroper opened this issue Feb 21, 2018 · 3 comments
Closed

Publish with stable JDK9 module name #546

jroper opened this issue Feb 21, 2018 · 3 comments
Milestone
1.3.3

Comments

@jroper
Copy link
Member

jroper commented Feb 21, 2018

Typesafe config currently gets an automatic module name of config, since the artifact name is config. This is a recipe for conflict. This can be solved by adding an Automatic-Module-Name attribute to the jar manifest. I suggest we name it com.typesafe.config, or just typesafe.config.
jroper added a commit to jroper/config that referenced this issue Feb 21, 2018
@jroper
Publish with namespaced JDK9 module name
dcd1435 
Fixes lightbend#546.

Adds Automatic-Module-Name: typesafe.config, rather than defaulting to
the very generic module name of config that the JVM selects.
@jroper jroper mentioned this issue Feb 21, 2018
Merged
ktoso pushed a commit that referenced this issue Feb 21, 2018
@jroper @ktoso
Publish with namespaced JDK9 module name (#547)
76ff0bd 
Fixes #546.

Adds Automatic-Module-Name: typesafe.config, rather than defaulting to
the very generic module name of config that the JVM selects.
@ktoso ktoso added this to the 1.3.3 milestone Feb 21, 2018
@ktoso
Copy link
Contributor

ktoso commented Feb 21, 2018

1.3.3 was released @jroper @havocp @2m :)

@havocp
Copy link
Collaborator

havocp commented Feb 21, 2018

@ktoso can you add a note to NEWS.md ? ( release steps in https://github.com/lightbend/config/blob/master/CONTRIBUTING.md of course) thanks!

@ktoso
Copy link
Contributor

ktoso commented Feb 21, 2018

Man, sorry for missing process, will follow up steps

aalleexxeeii pushed a commit to aalleexxeeii/typesafe-config that referenced this issue Jun 6, 2018
@jroper @ktoso
Publish with namespaced JDK9 module name (lightbend#547)
d284ee5 
Fixes lightbend#546.

Adds Automatic-Module-Name: typesafe.config, rather than defaulting to
the very generic module name of config that the JVM selects.
@lion7 lion7 mentioned this issue Aug 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.3
Development

No branches or pull requests
3 participants
@jroper @ktoso @havocp