Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #739: Mention TASTy-MiMa in the readme. #740

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

sjrd
Copy link
Contributor

@sjrd sjrd commented Jan 30, 2023

First attempt to see if @SethTisue is happy with it. :)

@lightbend-cla-validator
Copy link
Collaborator

Hi @sjrd,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

@sjrd
Copy link
Contributor Author

sjrd commented Jan 30, 2023

I signed the CLA.

README.md Outdated
Comment on lines 46 to 47
Keep in mind that TASTy-MiMa is a very young project, and likely to contain
(many) bugs at the moment.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Keep in mind that TASTy-MiMa is a very young project, and likely to contain
(many) bugs at the moment.
Keep in mind that TASTy-MiMa is still young, as of early 2023. It is likely to contain bugs.

Copy link
Collaborator

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to sign the CLA :-)

@sjrd sjrd force-pushed the mention-tasty-mima branch from ad96f3e to bc6b02f Compare January 30, 2023 17:24
@sjrd
Copy link
Contributor Author

sjrd commented Jan 30, 2023

Thanks, done.

@SethTisue SethTisue merged commit 56cca47 into lightbend-labs:main Feb 1, 2023
@sjrd sjrd deleted the mention-tasty-mima branch February 1, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants