remove dependency on scala-collection-compat #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that by removing a dependency you broke backward binary compatibility, since an artifact compiled with 0.9.0 may expect scala-collection-compat to be on the classpath, but an update to 0.9.1 does not bring it anymore. (I don’t think this is a big deal, but I just wanted to let you know) |
|
I don't consider transitive dependencies to be under any kind of guarantee by a library. I'm not saying it's not a "breakage" of some form, but I consider it a user-side issue rather than the library's: if you need scala-collection-compat on the classpath, then declare it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is easier than arguing with dbuild about conflicting cross-version suffixes over at scala/community-build#1407