Removed overloads are missing, not incompatible #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the method checker didn't take overloading into account, which means that the loss of a method overloading (which includes the loss of a static forwarder methods, when upgrading from Scala 2.12.7 to 2.12.8+) was reported as an "incompatible method type" problem or a "incompatible result type" problem. With this change these are now correctly reported as "direct missing method" problems.
|
This is in relation to #361, where it was discovered that the change in 2.12.8 that dropped the method overload for static forwarders for bridge methods (for example static |
lrytz
reviewed
Jul 30, 2019
| else | ||
| super.check(method, inclazz.lookupClassMethods(method.bytecodeName)) | ||
| super.check(method, inclazz, _.lookupClassMethods(method.bytecodeName)) |
There was a problem hiding this comment.
The lookup function is used for old and new, I wonder if there is a case when we get a misleading error message if a method is removed and only exists in a parent trait in the new version.
Generally, maybe can you explain why a different lookup function is used if meth.isDeferred?
There was a problem hiding this comment.
No, I can't. It's a part of the code that I don't understand and just try to preserve the existing semantics.
dwijnand
added a commit
to dwijnand/mima
that referenced
this pull request
Oct 5, 2019
In lightbend-labs#362 I changed the logic so that when an overloaded is dropped it doesn't get reported as an "incompatible method type" or "incompatible result type" problem. Looking back the logic is quite short-sighted. So here I attempt to make it more straight-forward: if there were overloads, then the method is missing - it's not incompatible.
dwijnand
added a commit
to dwijnand/mima
that referenced
this pull request
Oct 5, 2019
In lightbend-labs#362 I changed the logic so that when an overloaded is dropped it doesn't get reported as an "incompatible method type" or "incompatible result type" problem. Looking back the logic is quite short-sighted. So here I attempt to make it more straight-forward: if there were overloads, then the method is missing - it's not incompatible.
dwijnand
added a commit
to dwijnand/mima
that referenced
this pull request
Oct 5, 2019
In lightbend-labs#362 I changed the logic so that when an overloaded is dropped it doesn't get reported as an "incompatible method type" or "incompatible result type" problem. Looking back the logic is quite short-sighted. So here I attempt to make it more straight-forward: if there were overloads, then the method is missing - it's not incompatible.
dwijnand
added a commit
to dwijnand/mima
that referenced
this pull request
Oct 5, 2019
In lightbend-labs#362 I changed the logic so that when an overloaded is dropped it doesn't get reported as an "incompatible method type" or "incompatible result type" problem. Looking back the logic is quite short-sighted. So here I attempt to make it more straight-forward: if there were overloads, then the method is missing - it's not incompatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the method checker didn't take overloading into account, which
means that the loss of a method overload (which includes the loss of a
static forwarder method overload, such as when upgrading from Scala 2.12.7 to 2.12.8+) was
reported as an "incompatible method type" problem or a
"incompatible result type" problem.
With this change these are now correctly reported as "direct missing
method" problems.