Verify all overloads for result types & signatures #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use slash syntax, string interpolation & non-infix syntax * make most things private * define a utility dirContaining filter
With this, running "IntegrationTest / test" or "functional-tests / IntegrationTest / test" will no longer run the functional tests.
Also: * use Source.fromFile * make case classes final * use Set if used for contains * use "msg" instead of "mess"! (lol) * use collection's addString
Instead of taking the first method which "matches type" (which actually means "has the same parameters") to check whether the result types also match, check them all. The impact is visible in the integration test changes: ZipArchive's underlyingSource is "just" a (generic) signature problem, not a result type problem. Specifically it still returns a scala.Some, except it's a: > ()Lscala/Some<Lscala/reflect/io/AbstractFile;>; rather than ()Lscala/Some<Lscala/reflect/io/ZipArchive;>;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of taking the first method which "matches type" (which actually
means "has the same parameters") to check whether the result types also
match, check them all.
The impact is visible in the integration test changes: ZipArchive's
underlyingSource is "just" a (generic) signature problem, not a result type
problem. Specifically it still returns a scala.Some, except it's a:
... preceeded by a CollectProblemsTest improvement, a functional test setup fix & cleanup.