-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on changes in method Signature (e.g. generics) #299
Warn on changes in method Signature (e.g. generics) #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, do we need a way to disable the feature (in case someone want the old behavior)?
The new behavior results in problems of the new type The integration tests reveal this PR also introduces some new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d1b3a8c
to
74bbe43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
OK, I checked MiMa from this branch with akka-http, and while I had to add a bunch of new filters (akka/akka-http#2538), they do seem legitimate. |
👍, maybe some migration notes could be added somewhere that you can expect new problems that need to be fixed / excluded and how to exclude all if you don't care? |
I think this would best fit in the GitHub 'Release'. Something like: This release introduces a new problem type, the This release also fixes a problem where ? |
Sounds good! |
74bbe43
to
83b6c6a
Compare
Thought we'd merged this already, so my repo structure changes broke this. I also realised in doing that that this PR was deleting a |
|
83b6c6a
to
d73f674
Compare
Folded into the first commit. |
See #40