Fix false positive when migrating from Java varargs to @varargs
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure why this was done and/or what's changed in 2.5 years, but only one test failed (in different ways) and the fix was right. And also it seemed to have found a binary incompatibility between scala-reflect 2.10.0 & 2.10.7! :D
dwijnand
force-pushed
the
java-varargs-to-Scala-annotated-varargs
branch
from
eab5473 to
0efa79c
Compare
|
OK, Travis CI is green now, so I rewrote the commits and this is ready for review now. |
|
Thanks for the fix, @dwijnand! |
dwijnand
changed the title
@varargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
I'd love some feedback or review by @szeiger and/or @retronym seeing as the first commit undoes a major piece of #142