Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package name for nested packages, in 2.12 #181

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Fix package name for nested packages, in 2.12 #181

merged 1 commit into from
Jul 22, 2017

Conversation

dwijnand
Copy link
Collaborator

This was causing no class to be found (!!) because it would define the
package as "pp.q" instead of "p.q".

@dwijnand dwijnand requested a review from szeiger July 21, 2017 10:13
Copy link
Contributor

@szeiger szeiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have been caused by the refactoring to the 2.12 classpath handling. I've seen and fixed a similar case while testing those changes.

@lrytz
Copy link
Contributor

lrytz commented Jul 21, 2017

Do you know what is the condition to trigger this bug? In my local test MiMa 0.1.14 works correctly, also with a class p.q.A (https://github.com/lrytz/mima-test/commits/master)

@dwijnand
Copy link
Collaborator Author

You need to be running the 2.12 code path of MiMa, so switch to sbt 1.0.0-RC2. Then MiMa will false negative:

sbt:c> mimaReportBinaryIssues
[info] Compiling 1 Scala source to /s/mima-test/target/scala-2.12/classes ...

[info] Done compiling.

[info] c: found 0 potential binary incompatibilities while checking against a.b:c_2.12:0.0.1

[info] Total time: 1 s, completed 21-Jul-2017 11:41:21

@lrytz
Copy link
Contributor

lrytz commented Jul 21, 2017

Got it, thanks. Yes, it reproduces.

This was causing no class to be found (!!) because it would define the
package as "pp.q" instead of "p.q".
@dwijnand dwijnand merged commit 73112c5 into lightbend-labs:master Jul 22, 2017
@dwijnand dwijnand deleted the pkgname branch July 22, 2017 08:33
@dwijnand dwijnand added this to the 0.1.15 milestone Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants