convert filter definitions to taskKeys #157
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to load the filter definitions from something else than source code without having to reload the project after having changed the filters.
2m
approved these changes
Dec 23, 2016
|
LGTM |
SethTisue
approved these changes
Jan 10, 2017
|
This might lead to #102 being fixed. Which would allow the Scala build to move to the sbt plugin rather than process forking to call MiMa's main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to load the filter definitions from something else than
source code without having to reload the project after having changed the
filters.
We are currently experimenting with moving the filters to external files so that the filters don't have to be compiled so often (IIRC big
Seq(...)expressions can be quite costly for type inference). See akka/akka-http#677. If that approach works well it might make sense to move it here as well.