Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat default value getters as accessible. #145

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

szeiger
Copy link
Contributor

@szeiger szeiger commented Nov 23, 2016

They are called from other compilation units and their names can change
when a new overload is added to a method with default values.

Fixes #136.

They are called from other compilation units and their names can change
when a new overload is added to a method with default values.

Fixes lightbend-labs#136.
@szeiger szeiger added this to the 0.1.12 milestone Nov 28, 2016
@SethTisue
Copy link
Collaborator

SethTisue commented Nov 29, 2016

review by @adriaanm (as per team meeting) — on the fast track for 2.11.9 + 2.12.1

@adriaanm
Copy link
Contributor

LGTM!

@adriaanm adriaanm merged commit e083f6d into lightbend-labs:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants