-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: no assembly, missing main class to start with java -jar #166
Comments
you'll need to provide
|
@SethTisue : why not provide the assembly task? It would simpler (I know, everyone loves to build classpath by hand, but still, for the laziest of us :). And it would match the documentation. |
I see now that we didn't update https://github.com/typesafehub/migration-manager/wiki/MiMa-Command-Line-Tool at the time we removed the assembly stuff; that was an oversight. (EDIT: I added a note to the top just now, pending the outcome of this discussion.)
Well, I don't have a strong feeling about it one way or the other. The main goal of #155 was to get rid of the S3 stuff and simplify our release process. The assembly stuff came out at the same time, just because everyone we asked was only using the sbt plugin, so it wasn't clear the assembly stuff was worth continuing to maintain. I don't think we want to go to the effort of actually publishing the assembly jar unless there's a strong indication that it would have more than a handful of users. But if someone wants to a submit a PR restoring the assembly task to the build, I wouldn't be opposed. |
OH, I don't think you need to publish an assembly, but having the task would simplify the use of the CLI. |
…labs#155 along with s3 deploy
PR is here: #167 |
I tried to build mima to use from the CLI.
There is no documentation to do so, so I tried a
sbt packages
But then, I get:
I 'm wondering if #155 didn't remove/broke the assembly target.
The text was updated successfully, but these errors were encountered: