Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Changing construction of the first guess and coefficient matrices in …
…NLTE solver (tardis-sn#2201) * implementing nlte_excitation * ran black * fixed a typo * got rid of unnecessary lines * rewrote tests * made a change on assigning the config values to plasma properties * fixed the tests * Update tardis/io/tests/test_config_reader.py Co-authored-by: Christian Vogl <[email protected]> * restructured the first guess for NLTE solver to be compatible with NLTE excitation too * ran black * modified the existing rates to change when treating species with NLTE excitation * nlte not implemented, remove from rate_matrix_index * ran black * fixed an issue with one of the tests * attempt of adding bound bound interaction coefficients * fixed an issue with bound bound rates matrix * added docstrings * ran black * changed one of the methods to static * added test for bound bound rates part of the matrix * ran black * added docstrings to nlteexcitationdata * got rid of unnecessary import * added a new parameter to the docsting of the method * got rid of the number conservation row for the bound-bound matrix as it will be added on in the overall matrix construction * ran black * remodified the tests * fixed a loop issue * added a todo comment * renamed a function * updated a docstring * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * got rid of t_electrons * resolved an issue with tests * added additional information into a docstring * added a docstring * got rid of unnecessary grouping of rates * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Wolfgang Kerzendorf <[email protected]> * fixing a minor issue in tests * separated nlte excitation coefficients * running black * separating beta sobolev related stuff from the rest of the bound bound matrix * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * factored prepare_bound_bound_rate_matrix * removed an unnecessary function for excitation rates * removed unnecessary method for concatinating rates for NLTE excitation * ran black on nlte_rate_equation_solver * got rid of an unnecessary method * fixed a typo * small fixed * modified the j_blues and beta_sobolevs used in the tests * running black once again * adding rate_matrix_index to first guess docstring * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * Update tardis/plasma/tests/test_nlte_excitation.py Co-authored-by: Christian Vogl <[email protected]> * fixed a typo * switched from using the atomic_data_levels to number_of_levels * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * fixed the issue with tests * ran black once again * left a comment for future generations of NLTE youth * ran black once again * Update tardis/plasma/properties/nlte_rate_equation_solver.py Co-authored-by: Christian Vogl <[email protected]> * got rid of an unnecessary argument --------- Co-authored-by: Christian Vogl <[email protected]> Co-authored-by: Wolfgang Kerzendorf <[email protected]>
- Loading branch information