Add functions for Rainbow #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…symetrising parameter instead of amplitude
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #411 will not alter performanceComparing Summary
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #411 +/- ##
=======================================
Coverage 82.41% 82.41%
=======================================
Files 9 9
Lines 2565 2565
=======================================
Hits 2114 2114
Misses 451 451 ☔ View full report in Codecov by Sentry. |
hombit
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
It looks great to me!
I'd be nice if @karpov-sv could also review it
karpov-sv
reviewed
Sep 13, 2024
light-curve/light_curve/light_curve_py/features/rainbow/bolometric.py
Outdated
Show resolved
Hide resolved
karpov-sv
reviewed
Sep 13, 2024
karpov-sv
reviewed
Sep 13, 2024
light-curve/light_curve/light_curve_py/features/rainbow/bolometric.py
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.