Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple providers and dynamic configuration #76

Conversation

mariuszkochanowski
Copy link
Contributor

@mariuszkochanowski mariuszkochanowski commented Mar 11, 2018

This adds ability to:

  1. use multiple file providers (also embedded file provider)
  2. use dynamic confguration like:
<script type="text/javascript" src="~/Scripts1/Script1.js" asp-append-version="true" asp-bundle-key="bundle1"></script>
<script type="text/javascript" src="~/Scripts2/Script2.js" asp-append-version="true" asp-bundle-key="bundle1"></script>
<script type="text/javascript" src="~/js/Script3.js" asp-append-version="true" asp-bundle-key="bundle1"></script>
<script type="text/javascript" src="~/EmbeddedResourcesScripts/EmbeddedScript1.js" asp-append-version="true" asp-bundle-key="bundle1"></script>
<script type="text/javascript" src="~/EmbeddedResourcesScripts/Scripts/EmbeddedScript2.js" asp-append-version="true" asp-bundle-key="bundle1"></script>

<script type="text/javascript" asp-bundle-dest-key="bundle1"></script>

I added tag helpers that inherit from the built-in mvc helpers so you can use them interchangeably:

  • configuration "enableTagHelperBundling": true
    renders one file with appended file version
  • configuration "enableTagHelperBundling": false
    renders all files separately with own file versions

Take a look at sample WebOptimizer.Core.Sample2

@madskristensen
Copy link
Member

Looks awesome. Thank you!!

@madskristensen madskristensen merged commit e3e169e into ligershark:master Mar 16, 2018
madskristensen pushed a commit that referenced this pull request Mar 22, 2018
* Adds customizable cache directory and ...

... Enable/Disable of Memory and Disk Caches.  See #74 and #77.

* Fixes #79 Asset.ExpandGlobs got broken in PR #76

* Added examples for options
@mariuszkochanowski mariuszkochanowski deleted the MultipleProvidersAndDynamicConfiguration branch March 23, 2018 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants