Instruction category for indirect jump & function return #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoodman
approved these changes
Apr 12, 2021
ekilmer
added a commit
to ekilmer/remill
that referenced
this pull request
Jun 9, 2021
* master: Fixup cxx-common links (lifting-bits#519) Use cxx-common 0.1.4 (lifting-bits#517) Use system compiler to build (lifting-bits#516) Build with LLVM 12 (lifting-bits#515) docs: Update stale links (lifting-bits#514) Workaround LLVM hardcoded include directory (lifting-bits#513) X86 segment reg override (lifting-bits#512) CI: Use v0.1.3 (latest) cxx-common prebuilt libraries (lifting-bits#511) Error out if there are fewer than four bytes to decode. (lifting-bits#510) arch: Fix widening issues when dst is gpr register on x86_64. (lifting-bits#509) Find module in build ptr to offset (lifting-bits#508) Fix FCOMPmem and FUCOMPmem (lifting-bits#507) Use clang from vcpkg in build script (lifting-bits#506) BuildPointerToOffset assumes it makes progress (lifting-bits#505) Update instruction category for indirect jump & function return (lifting-bits#503) treat all pop to pc as function return (lifting-bits#502)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR reverts some of the changes that identify the updates of
PCwith the return address. All instructions updating PC directly withLR(return address) are categorized as return type. Others get categorized as indirect Jump. At a later stage, the lifter will identify if the return address ends up getting into PC and handle them accordingly.