Support no_std in hexf-parse.
#28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support `no_std` in hexf-parse, by adding a "std" feature, enabled by default, and putting the impl of `std::error::Error` behind it.
|
ps looks like |
|
I've now updated the PR to use |
youknowone
reviewed
Dec 4, 2024
Comment on lines
+63
to
+75
| #[cfg(feature = "std")] | ||
| impl std::error::Error for ParseHexfError { | ||
| fn description(&self) -> &'static str { | ||
| self.text() | ||
| } | ||
| } | ||
|
|
||
| #[cfg(not(feature = "std"))] | ||
| impl core::error::Error for ParseHexfError { | ||
| fn description(&self) -> &'static str { | ||
| self.text() | ||
| } | ||
| } |
There was a problem hiding this comment.
Can this be simply replaced to core::error::Error? Otherwise are those different types?
Suggested change
| #[cfg(feature = "std")] | |
| impl std::error::Error for ParseHexfError { | |
| fn description(&self) -> &'static str { | |
| self.text() | |
| } | |
| } | |
| #[cfg(not(feature = "std"))] | |
| impl core::error::Error for ParseHexfError { | |
| fn description(&self) -> &'static str { | |
| self.text() | |
| } | |
| } | |
| impl core::error::Error for ParseHexfError { | |
| fn description(&self) -> &'static str { | |
| self.text() | |
| } | |
| } |
There was a problem hiding this comment.
The README.md advertises support for Rust 1.43; core::error::Error was introduced in Rust 1.81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
no_stdin hexf-parse, by adding a "std" feature, enabled by default, and putting the impl ofstd::error::Errorbehind it.