Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints to handle authorization policies #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo in API docstring
LaPetiteSouris committed Nov 23, 2022

Verified

This commit was signed with the committer’s verified signature.
markpash Mark Pashmfouroush
commit 4622b75a3cda1b2df09d209df30581b8a8e2ac54
5 changes: 3 additions & 2 deletions api.proto
Original file line number Diff line number Diff line change
@@ -302,6 +302,7 @@ message ACLPolicy {
string resourceId = 2;
string action = 3;
}

// AddPolicyRequest is sent by the client to the metadata leader to add a new authorization policy.
message AddPolicyRequest {
ACLPolicy policy = 1;
@@ -322,7 +323,7 @@ message RevokePolicyResponse {
// Intentionally empty
}

// ListPolicyRequest is sent by the client ot metadata leader to list all existing ACL policies on all resources.
// ListPolicyRequest is sent by the client to the metadata leader to list all existing ACL policies on all resources.
message ListPolicyRequest {
// Intentionally empty
}
@@ -598,7 +599,7 @@ service API {
// included as part of Liftbridge's semantic versioning scheme.
rpc ReportConsumerGroupCoordinator(ReportConsumerGroupCoordinatorRequest) returns (ReportConsumerGroupCoordinatorResponse) {}

// AddPolicy add an ACL policy to the cluster
// AddPolicy adds an ACL policy to the cluster
rpc AddPolicy(AddPolicyRequest) returns (AddPolicyResponse) {}

// RevokePolicy revokes an existing ACL policy from the cluster
6 changes: 3 additions & 3 deletions go/api.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion py/api_pb2_grpc.py
Original file line number Diff line number Diff line change
@@ -271,7 +271,7 @@ def ReportConsumerGroupCoordinator(self, request, context):
raise NotImplementedError('Method not implemented!')

def AddPolicy(self, request, context):
"""AddPolicy add an ACL policy to the cluster
"""AddPolicy adds an ACL policy to the cluster
"""
context.set_code(grpc.StatusCode.UNIMPLEMENTED)
context.set_details('Method not implemented!')