LPS-147076 #1682

mbowerman · 2022-09-12T20:30:07Z

Patched third-party org.apache.velocity .jar file with changes from apache/velocity-engine#16 to resolve CVE-2020-13936.

apache/velocity-engine#16 to SecureIntrospectorImpl to resolve CVE-2020-13936

liferay-continuous-integration · 2022-09-12T20:30:13Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2022-09-12T20:53:26Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 22 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 823a5121de53e7851e7017e037ce8a8890b1cfe5

Sender Branch:

Branch Name: LPS-147076
Branch GIT ID: f0b95880c7f635c30bba5796637bbb677d18d6ca

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2022-09-12T20:57:54Z

Jenkins Build:test-portal-source-format#6521

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-core-infra#1682

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - mbowerman > liferay-core-infra - PR#1682 - 2022-09-12[13:31:11]

Testray Importer:publish-testray-report#2916

lib/versions-complete.xml

dantewang · 2022-09-13T02:44:14Z

@catarineaguiar Could you review the test results when they finish? Thanks!

dantewang

@tinatian Code looks good. Waiting for test results and QA check.

catarineaguiar · 2022-09-14T12:24:16Z

ci:test:relevant

liferay-continuous-integration · 2022-09-14T15:19:15Z

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 123 out of 180 jobs passed in 2 hours 53 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1327401_5793

Base Branch:

Branch Name: master
Branch GIT ID: 840c9a5d114cc58f36c3baf695c13d3c68f92d01

Upstream Comparison:

Branch GIT ID: 7fe3fcc7dd7578866b6e758c90769c47003b2a06
Jenkins Build URL: EE Development Acceptance (master) - 3798 - 2022-09-13[20:29:27]

ci:test:stable - 27 out of 27 jobs PASSED

27 Successful Jobs:

ci:test:relevant - 123 out of 180 jobs PASSED

57 Failed Jobs:

123 Successful Jobs:

For more details click here.

Failures unique to this pull:

semantic-versioning-jdk8/0/0

clean-up-java-processes:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
[stopwatch] [run.batch.test.setup: 34:01.933 sec]
     [echo] run.batch.test.action.start.timestamp: 09-14-2022 07:52:18:917 PDT
     [echo] Checking for baseline log files.
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-kernel.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 74.0.0
[beanshell] 
[stopwatch] [run.batch.test.action: 8.557 sec]
     [echo] Semantic versioning is incorrect.
      [get] Getting: ${dependencies.url}/archive/test-1-21/test-portal-acceptance-pullrequest-downstream(master)/84052consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220914075227475.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220914075227475.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null2041044067.properties

modules-unit-jdk8/0/3

com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtilTest.classMethod

java.lang.AssertionError: com.liferay.portal.configuration.metatype.bnd.util.ConfigurableUtil is not fully covered
  at com.liferay.whip.agent.InstrumentationAgent._assertClassDataCoverage(InstrumentationAgent.java:343)
  at com.liferay.whip.agent.InstrumentationAgent.assertCoverage(InstrumentationAgent.java:66)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor.afterClass(CodeCoverageAssertor.java:119)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:84)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
  at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
  at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
  at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
  at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
  at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClas...

com.liferay.portal.proxy.internal.ASMDelegateProxyFactoryTest.classMethod

java.lang.AssertionError: com.liferay.portal.proxy.internal.ASMDelegateProxyFactory is not fully covered
  at com.liferay.whip.agent.InstrumentationAgent._assertClassDataCoverage(InstrumentationAgent.java:343)
  at com.liferay.whip.agent.InstrumentationAgent.assertCoverage(InstrumentationAgent.java:66)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor.afterClass(CodeCoverageAssertor.java:119)
  at com.liferay.portal.kernel.test.rule.CodeCoverageAssertor$1.evaluate(CodeCoverageAssertor.java:84)
  at org.junit.rules.RunRules.evaluate(RunRules.java:20)
  at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
  at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
  at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
  at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
  at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
  at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor...

Failures in common with acceptance upstream results at 7fe3fcc:

functional-tomcat90-mysql57-jdk8/0/1
1. LocalFile.SAML#AssertAuthorizationOnOAuth2WithSAMLConnectionWithExistingUser - Poshi Report - Poshi Summary - Console Output

modules-integration-mysql57-jdk8/0/0

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Table 'lportal.User_x_51805' doesn't exist
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

modules-integration-mysql57-jdk8/0/1

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Table 'lportal.User_x_45328' doesn't exist
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-09-14T15:30:34Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5793

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-core-infra#1682

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - mbowerman > liferay-core-infra - PR#1682 - 2022-09-14[05:24:28]

Testray Importer:publish-testray-report#15257

catarineaguiar · 2022-09-14T16:52:11Z

@mbowerman @dantewang no regressions found.

tinatian · 2022-09-16T23:44:57Z

@shuyangzhou This pull is good to go.

Tina

tinatian · 2022-09-19T16:19:28Z

See brianchandotcom#123354

mbowerman added 6 commits September 12, 2022 10:21

LPS-147076 Initial State

3a0e9dd

LPS-147076 Apply changes from

1ae2a37

apache/velocity-engine#16 to SecureIntrospectorImpl to resolve CVE-2020-13936

LPS-147076 FAKE GRADLE CACHE

3cb84e0

LPS-147076 Enforce update

4d11f49

LPS-147076 Auto SF

b683125

LPS-147076 Build lib versions

f0b9588

mbowerman mentioned this pull request Sep 12, 2022

LPS-147076 #1679

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Sep 12, 2022

dantewang reviewed Sep 13, 2022

View reviewed changes

lib/versions-complete.xml Show resolved Hide resolved

dantewang assigned dantewang and catarineaguiar Sep 13, 2022

dantewang approved these changes Sep 13, 2022

View reviewed changes

dantewang assigned tinatian and unassigned dantewang Sep 13, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Sep 14, 2022

tinatian assigned shuyangzhou and unassigned tinatian and catarineaguiar Sep 16, 2022

tinatian closed this Sep 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-147076 #1682

LPS-147076 #1682

mbowerman commented Sep 12, 2022

liferay-continuous-integration commented Sep 12, 2022

liferay-continuous-integration commented Sep 12, 2022

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 12, 2022

dantewang commented Sep 13, 2022

dantewang left a comment

catarineaguiar commented Sep 14, 2022

liferay-continuous-integration commented Sep 14, 2022

Base Branch:

Upstream Comparison:

57 Failed Jobs:

For more details click here.

Failures unique to this pull:

liferay-continuous-integration commented Sep 14, 2022

catarineaguiar commented Sep 14, 2022

tinatian commented Sep 16, 2022

tinatian commented Sep 19, 2022

LPS-147076 #1682

LPS-147076 #1682

Conversation

mbowerman commented Sep 12, 2022

liferay-continuous-integration commented Sep 12, 2022

liferay-continuous-integration commented Sep 12, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 22 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 12, 2022

dantewang commented Sep 13, 2022

dantewang left a comment

Choose a reason for hiding this comment

catarineaguiar commented Sep 14, 2022

liferay-continuous-integration commented Sep 14, 2022

✔️ ci:test:stable - 27 out of 27 jobs passed

❌ ci:test:relevant - 123 out of 180 jobs passed in 2 hours 53 minutes

Base Branch:

Upstream Comparison:

57 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Sep 14, 2022

catarineaguiar commented Sep 14, 2022

tinatian commented Sep 16, 2022

tinatian commented Sep 19, 2022