fix: remove type-fest to improve compatibility #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkdowdle
approved these changes
Jan 18, 2024
aecorredor
approved these changes
Jan 18, 2024
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'd like to propose removing
type-festto improve the compatibility of this library. The current version oftype-festused here has an implicit requirement around the version of TypeScript, and I'm struggling to identify it.In my experience, this is common with
type-fest-- since they're providing complex typings, they often rely on TS syntax that may be only recently supported, or is at the least version specific.While I love
type-fest, I think this might make it not ideal for this project, which is itself a package. Removingtype-festwill make the project more compatible with consumers of various TypeScript versions.