Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a simple scan table method #16

Closed
wants to merge 1 commit into from
Closed

feat: add a simple scan table method #16

wants to merge 1 commit into from

Conversation

jkdowdle
Copy link
Contributor

@jkdowdle jkdowdle commented Dec 11, 2023 •
edited
Loading

Motivation

Found a need for using a scan operation on a dynamo table and I wanted to use dynamost

This does not do anything but do a scan on the database. nothing like providing filters etc. If we prefer we could close this and go with #17 to support the filtering attributes

@jkdowdle jkdowdle mentioned this pull request Dec 11, 2023
Merged
aecorredor
aecorredor reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@aecorredor aecorredor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed #17 instead.

swain
swain reviewed Dec 12, 2023
View reviewed changes
Copy link

@swain swain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto. I think #17 is better

@jkdowdle jkdowdle closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aecorredor aecorredor aecorredor left review comments

@swain swain swain left review comments

@nicolls1 nicolls1 Awaiting requested review from nicolls1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkdowdle @aecorredor @swain