mocks as a readonly array #70
Conversation
In `MockedProvider` in `@apollo/client/testing`, the array is readonly which creates an error when matching the types.
|
@lifeiscontent let me know if there's a specific procedure for changes |
|
Should I be doing anything @lifeiscontent? This looks good to me. |
|
@lifeiscontent anything I can do to get this moving? Happy to have the PR rejected or to know I should be doing more. |
|
@saiichihashimoto sorry, I've been a bit busy lately and haven't had a ton of time for open source. Thanks for the contribution! |
|
@saiichihashimoto actually, if you have some time on your hands, I could really use some help. I have been planning to migrate to the same release process as https://github.com/lifeiscontent/storybook-addon-next-router if I gave you an outline would you be willing to help with it so I can publish a new version for you to use? |
|
Honestly, I don't have the time. We're on a tight release schedule and I don't have the time to allocate to this, I was making a quick contribution as I included a |
|
@saiichihashimoto released your changes in latest version. Thanks for your contribution! |
In
MockedProviderin@apollo/client/testing, the array is readonly which creates an error when matching the types.This is a quick bug fix; the true solution involves using
MockedProvidertypes from@apollo/client/testingdirectly. The intended use case of this package is to drop inMockedProvider, so the types should be one-to-one.