Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero and Light theme #185

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Hero and Light theme #185

merged 3 commits into from
Nov 6, 2022

Conversation

khalilcodes
Copy link
Contributor

Summary

Tasks from #181

Merging this PR adds a hero component to LI frontpage and defaults the theme to light mode.

Changes

  • Add a hero component in content/components/ which symlinks to components/custom (as we have in flowershow)
  • Remove the symlinked components/ecosystem as two ecosystem folders were then present after doing above.
  • Update the ecosystem imports in related files.
  • Add the Hero image from original LI site into assets - lifeitself-landingpage.webp. Webp is smaller in size 4.6mb --> ~330kb
  • Add default light theme in config.js

Hero Screenshot

Screen Shot 2022-11-05 at 7 42 31 PM

@netlify
Copy link

netlify bot commented Nov 5, 2022

Deploy Preview for zesty-liger-3a5c29 ready!

Name Link
🔨 Latest commit 8929f33
🔍 Latest deploy log https://app.netlify.com/sites/zesty-liger-3a5c29/deploys/636684d36d7ced000753c52d
😎 Deploy Preview https://deploy-preview-185--zesty-liger-3a5c29.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rufuspollock rufuspollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. one question is why we have "custom" components (rather than just directly symlinking ecosystem or site component section but not a big deal IMO.

@@ -0,0 +1,26 @@
export default function Hero() {
return (
<main className="lg:relative">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this should be a <section> rather <main>?

@rufuspollock rufuspollock merged commit 2b5985c into main Nov 6, 2022
@rufuspollock rufuspollock deleted the 181-hero-component branch November 6, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants