Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pydata-sphinx-theme version to fix docs #60

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Pin pydata-sphinx-theme version to fix docs #60

merged 2 commits into from
Mar 30, 2023

Conversation

jobrachem
Copy link
Contributor

@jobrachem jobrachem commented Mar 30, 2023

Apparently, the latest pydata-sphinx-theme release broke our usage of sphinx-book-theme.

This PR is a hotfix for this issue, it pins down the version. In the near future, a permanent fix will be merged in pydata-sphinx-theme:

@jobrachem jobrachem added bug Something isn't working comp:documentation Improvements or additions to the documentation labels Mar 30, 2023
@jobrachem jobrachem requested a review from hriebl March 30, 2023 08:11
@jobrachem jobrachem changed the title Fix docs Pin pydata-sphinx-version to fix docs Mar 30, 2023
@jobrachem jobrachem changed the title Pin pydata-sphinx-version to fix docs Pin pydata-sphinx-theme version to fix docs Mar 30, 2023
Copy link
Contributor

@hriebl hriebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@hriebl hriebl merged commit 3bc90b4 into main Mar 30, 2023
@hriebl hriebl deleted the fix-docs branch March 30, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp:documentation Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants