Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit tests] events #76

Merged
merged 2 commits into from
Dec 8, 2023
Merged

[unit tests] events #76

merged 2 commits into from
Dec 8, 2023

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Dec 6, 2023 •
edited
Loading

Description

  • unit tests for events
  • custom rpc input

Demo

image

Checklist:

  • Checked the changes locally.
  • Created/updated unit tests.
  • Created/updated README.md.

@Jeday Jeday requested a review from a team as a code owner December 6, 2023 10:17
solidovic
solidovic approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@solidovic solidovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • custom rpc input LGTM;
  • unit tests for events LGTM, but there are error in checks.

@Jeday
Copy link
Contributor Author

Jeday commented Dec 6, 2023

Errors in checks are unrelated. Working on fix via fork tests.

@Jeday Jeday merged commit 14783c3 into develop Dec 8, 2023
2 of 3 checks passed
@Jeday Jeday deleted the feature/si-855-unit-tests-events branch December 8, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solidovic solidovic solidovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jeday @solidovic