-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AA Support #554
Merged
Merged
AA Support #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-new-sdk Signed-off-by: Anton Shalimov <[email protected]>
Preview stand statusStand was demolished |
…o-new-sdk Signed-off-by: Anton Shalimov <[email protected]>
* refactor: remove the trick with LIDO_CONTRACT_NAMES * refactor(useWrapGasLimit): use the Promise.all + Promise.resolve(null)
…github.com:lidofinance/ethereum-staking-widget into feature/si-1714-aa-on-the-widget
DiRaiks
reviewed
Dec 4, 2024
solidovic
reviewed
Dec 4, 2024
solidovic
reviewed
Dec 4, 2024
…get into feature/si-1714-aa-on-the-widget
…get into feature/si-1714-aa-on-the-widget
solidovic
reviewed
Dec 11, 2024
solidovic
reviewed
Dec 11, 2024
solidovic
reviewed
Dec 11, 2024
solidovic
previously approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There are optional comment (suggests)
solidovic
previously approved these changes
Dec 12, 2024
solidovic
previously approved these changes
Dec 12, 2024
solidovic
previously approved these changes
Dec 12, 2024
…get into feature/si-1714-aa-on-the-widget
solidovic
approved these changes
Dec 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds alternative flow for wallets that support EIP5792. Key differences:
auxFunds
capability is present skip ETH balance check for stake/wrap eth to allow SA to funnel ETH from somewhere elsegetCapabilities
as before multisigs(now Smart Accounts), skip eth gas checkssendCalls
, batch allowance+tx if neededcallId
and showshow tx in wallet
button, that promts the wallet to show it's uiKey improvements:
Demo
Testing notes
Tested on:
Checklist: