Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AA Support #554

Merged
merged 30 commits into from
Dec 13, 2024
Merged

AA Support #554

merged 30 commits into from
Dec 13, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Dec 3, 2024

Description

This PR adds alternative flow for wallets that support EIP5792. Key differences:

  • if auxFunds capability is present skip ETH balance check for stake/wrap eth to allow SA to funnel ETH from somewhere else
  • treat all EIP5792 that respond correctly to getCapabilities as before multisigs(now Smart Accounts), skip eth gas checks
  • send transaction data via sendCalls, batch allowance+tx if needed
  • poll by callId and show show tx in wallet button, that promts the wallet to show it's ui
  • correctly show final tx

Key improvements:

  • 4437 wallets support
  • for Safe and other AA wallets better consistent UX with batching
  • support for future 7702 in Pectra
  • possible future proof if 5792 becomes widely supported
  • handover over gas,fees and transaction ux to wallet side where it belongs

Demo

image

Testing notes

Tested on:

  • Ambire extension SA
  • Safe Wallet( safe app)
  • Coinbase Smart wallet( sepolia)

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners December 3, 2024 08:33
@preview-stands
Copy link

preview-stands bot commented Dec 3, 2024

Preview stand status

Stand was demolished

Jeday and others added 6 commits December 3, 2024 20:09
* refactor: remove the trick with LIDO_CONTRACT_NAMES

* refactor(useWrapGasLimit): use the Promise.all + Promise.resolve(null)
…github.com:lidofinance/ethereum-staking-widget into feature/si-1714-aa-on-the-widget
@Jeday Jeday requested review from DiRaiks and solidovic December 5, 2024 11:01
@Jeday Jeday changed the title [WIP] AA on the widget AA on the widget Dec 9, 2024
@Jeday Jeday changed the title AA on the widget AA Support Dec 10, 2024
solidovic
solidovic previously approved these changes Dec 11, 2024
Copy link
Contributor

@solidovic solidovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are optional comment (suggests)

solidovic
solidovic previously approved these changes Dec 12, 2024
solidovic
solidovic previously approved these changes Dec 12, 2024
solidovic
solidovic previously approved these changes Dec 12, 2024
@Jeday Jeday merged commit 6853b5d into develop Dec 13, 2024
5 of 6 checks passed
@Jeday Jeday deleted the feature/si-1714-aa-on-the-widget branch December 13, 2024 13:27
@jake4take jake4take mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants