-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of external RPC #420
Merged
itaven
merged 7 commits into
develop
from
revert-412-revert-404-feature/si-1493-wallet-rpc-sync-error
Aug 6, 2024
Merged
Remove usage of external RPC #420
itaven
merged 7 commits into
develop
from
revert-412-revert-404-feature/si-1493-wallet-rpc-sync-error
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeday
changed the title
Revert Revert [fix] remove usage of wallet rpc during tx
Revert of Revert [fix] remove usage of wallet rpc during tx
Aug 1, 2024
Preview stand statusStand was demolished |
DiRaiks
previously approved these changes
Aug 1, 2024
Jeday
changed the title
Revert of Revert [fix] remove usage of wallet rpc during tx
Remove usage of external RPC
Aug 2, 2024
DiRaiks
previously approved these changes
Aug 5, 2024
…get into revert-412-revert-404-feature/si-1493-wallet-rpc-sync-error
DiRaiks
approved these changes
Aug 6, 2024
itaven
deleted the
revert-412-revert-404-feature/si-1493-wallet-rpc-sync-error
branch
August 6, 2024 12:03
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We use walletRPC for extra things apart from just sending TX for signing. This is not a problem when wallet is MetaMask, it handles extra RPC requests fine. For WalletConntect it's a problem because it does not have internal RPC, it uses default one from wagmi config. When users get rate limited by eth-cloudfare, it prevents tx signing and brings a whole lotta problems.
Solution
Extra
added
mock-qa-helpers-force-approval-withdrawal-wallet-connect
local storage mock