Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove input form from reward page #407

Merged
merged 42 commits into from
Aug 7, 2024
Merged

refactor: remove input form from reward page #407

merged 42 commits into from
Aug 7, 2024

Conversation

solidovic
Copy link
Contributor

@solidovic solidovic commented Jul 19, 2024 •
edited
Loading

Description

  1. Refactor banner:
    • not supported chain
    • not connected walet
  2. Remove input from rewards page.
  3. Refactor margin and color for texts.

Merge after:

Demo

Not connected

Снимок экрана 2024-08-07 в 15 14 18

Connected supported chain

Снимок экрана 2024-08-07 в 15 15 14

Connected unsupported chain

Снимок экрана 2024-08-07 в 15 17 12

Test notes

  • check matomo events (click the Connect button instead of rewards table)

  • added mock-qa-rewards-address mock for rewards table

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@solidovic solidovic changed the base branch from develop to feature/si-1310-unsupported-chain-banner-rework July 19, 2024 11:40
@solidovic solidovic marked this pull request as ready for review July 19, 2024 11:42
@solidovic solidovic requested review from a team as code owners July 19, 2024 11:42
@preview-stands
Copy link

preview-stands bot commented Jul 19, 2024 •
edited
Loading

Preview stand status

Stand was demolished

Base automatically changed from feature/si-1310-unsupported-chain-banner-rework to develop July 25, 2024 14:08
@solidovic solidovic requested a review from manneredboor July 31, 2024 12:00
Jeday
Jeday requested changes Aug 6, 2024
View reviewed changes
providers/rewardsHistory.tsx Outdated Show resolved Hide resolved
@solidovic solidovic requested a review from Jeday August 6, 2024 10:13
Jeday
Jeday previously approved these changes Aug 6, 2024
View reviewed changes
@solidovic solidovic requested a review from Jeday August 6, 2024 12:48
@jake4take jake4take merged commit 12d890f into develop Aug 7, 2024
6 checks passed
@jake4take jake4take deleted the feature/si-1497-reward-esw-remove-input-form branch August 7, 2024 12:24
@itaven itaven mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeday Jeday Jeday approved these changes

@manneredboor manneredboor Awaiting requested review from manneredboor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@solidovic @Jeday @manneredboor @jake4take