Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove using useWeb3 #399

Conversation

solidovic
Copy link
Contributor

@solidovic solidovic commented Jul 15, 2024

Description

Remove 'reef-knot/web3-react' package, except in two cases:

  • 'useSupportedChains' from 'reef-knot/web3-react';
  • 'helpers' from 'reef-knot/web3-react' (set TODO).

Merge after:

Testing notes

Check all the functionality related to:

  • connecting wallets;
  • rpc;
  • trx processing.

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@solidovic solidovic marked this pull request as ready for review July 16, 2024 11:57
@solidovic solidovic requested review from a team as code owners July 16, 2024 11:57
@solidovic solidovic changed the title [WIP] refactor: remove using useWeb3 refactor: remove using useWeb3 Jul 16, 2024
@preview-stands
Copy link

preview-stands bot commented Jul 16, 2024

Preview stand status

Stand was demolished

@solidovic solidovic changed the base branch from develop to feature/si-1310-unsupported-chain-banner-rework July 19, 2024 11:20
…eature/si-1481-remove-using-useweb3-from-reef-knotweb3-react-in-esw

Signed-off-by: Anton Shalimov <[email protected]>
DiRaiks
DiRaiks previously approved these changes Jul 19, 2024
Copy link
Contributor

@DiRaiks DiRaiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

alx-khramov
alx-khramov previously approved these changes Jul 19, 2024
Base automatically changed from feature/si-1310-unsupported-chain-banner-rework to develop July 25, 2024 14:08
@jake4take jake4take dismissed stale reviews from alx-khramov and DiRaiks July 25, 2024 14:08

The base branch was changed.

…-reef-knotweb3-react-in-esw

Signed-off-by: Anton Shalimov <[email protected]>
Jeday
Jeday previously approved these changes Aug 6, 2024
Jeday
Jeday previously approved these changes Aug 15, 2024
…-reef-knotweb3-react-in-esw

Signed-off-by: Anton Shalimov <[email protected]>
@solidovic solidovic requested a review from Jeday September 3, 2024 17:05
@jake4take jake4take merged commit 881d40c into develop Sep 4, 2024
6 checks passed
@jake4take jake4take deleted the feature/si-1481-remove-using-useweb3-from-reef-knotweb3-react-in-esw branch September 4, 2024 11:06
@itaven itaven mentioned this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants