-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: error boundary #374
Merged
Merged
feat: error boundary #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeday
previously approved these changes
Jun 28, 2024
Preview stand statusStand was demolished |
Jeday
previously approved these changes
Jul 3, 2024
DiRaiks
previously approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Anton Shalimov <[email protected]>
Jeday
approved these changes
Aug 6, 2024
DiRaiks
approved these changes
Aug 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catch any client-side errors via the concept of an "error boundary" and the NPM package "react-error-boundary".
Motivation of using "react-error-boundary"
The React error boundaries do not catch errors for:
onClick
To solve this issue, use the 'useErrorBoundary' hook:
https://www.npmjs.com/package/react-error-boundary#useerrorboundary-hook
Demo (not actual right now)
stake
page, there is a button that causes an error (features/stake/stake.tsx
)./wrap/unwrap
page, there is a 'useEffect' that causes an error (features/wsteth/unwrap/unwrap-form/unwrap-form.tsx
)In Prod mode
In Dev move
Checklist: