Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cors to all external endpoints #373

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Add Cors to all external endpoints #373

merged 1 commit into from
Aug 6, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Jun 27, 2024

Description

  • Add cors headers to all external endpoints
  • allow correct OPTIONS header behavior with method guard

Code review notes

Testing notes

Endpoints to test on /api:

  • eth-apr
  • eth-price
  • ldo-stats
  • lido-stats
  • lidostats
  • sma-steth-apr
  • totalsupply

Should have cors headers. Respond correctly to OPTIONS http request.

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners June 27, 2024 04:26
@preview-stands
Copy link

preview-stands bot commented Jun 27, 2024 •
edited
Loading

Preview stand status

Stand was demolished

@Vorobeyko Vorobeyko merged commit 4b7cb6c into develop Aug 6, 2024
9 of 11 checks passed
@Vorobeyko Vorobeyko deleted the feature/si-1457-change-method-guard branch August 6, 2024 08:02
@itaven itaven mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tarens2 Tarens2 Tarens2 approved these changes

@Vorobeyko Vorobeyko Vorobeyko approved these changes

@solidovic solidovic solidovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeday @solidovic @Vorobeyko @Tarens2