Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] add error toast for rpc and validation errors #347

Merged
merged 7 commits into from
Jun 19, 2024
Merged

[Feature] add error toast for rpc and validation errors #347

merged 7 commits into from
Jun 19, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Jun 7, 2024

Description

image

Demo

Code review notes

Testing notes

Block rpc to reproduce

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners June 7, 2024 11:05
@preview-stands
Copy link

preview-stands bot commented Jun 7, 2024 •
edited
Loading

Preview stand status

Stand was demolished

DiRaiks
DiRaiks requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@DiRaiks DiRaiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving the toast to the lower left corner so that it does not overlap the header interface.

@Jeday
Merge branch 'develop' of github.com:lidofinance/ethereum-staking-wid…
e5cbb28 
…get into feature/si-1308-improve-submit-validation-error-behavior
@Jeday Jeday requested a review from DiRaiks June 13, 2024 10:27
@Jeday Jeday requested a review from DiRaiks June 14, 2024 07:30
DiRaiks
DiRaiks previously approved these changes Jun 14, 2024
View reviewed changes
@jake4take jake4take merged commit 1bbb649 into develop Jun 19, 2024
6 checks passed
@jake4take jake4take deleted the feature/si-1308-improve-submit-validation-error-behavior branch June 19, 2024 11:37
@itaven itaven mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jake4take jake4take jake4take approved these changes

@DiRaiks DiRaiks DiRaiks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jeday @DiRaiks @jake4take