Update reef-knot to v2 #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview stand statusStand was demolished |
Jeday
previously approved these changes
Mar 6, 2024
…-eth-stake-widget-wagmi-autoconnect
Jeday
previously approved these changes
Mar 7, 2024
Jeday
previously approved these changes
Mar 11, 2024
…-eth-stake-widget-wagmi-autoconnect
solidovic
previously approved these changes
Mar 11, 2024
wagmi client was rebuilding because supportedChains wasn't memoized
Jeday
approved these changes
Mar 13, 2024
jake4take
approved these changes
Mar 13, 2024
jake4take
deleted the
feature/si-1300-update-reef-knot-to-v2-on-eth-stake-widget-wagmi-autoconnect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates Reef Knot to v2, which includes these changes:
lidofinance/reef-knot#119
Basically, it is about:
Code review notes
lido-sdkdependencies are completely removed from Reef Knot, but the widget is still using them, so I had to moveProviderSDKfrom'@lido-sdk/react'setup to the widget level. Hopefully it will be removed in the future.Testing notes
Please, check all the basic transactions too, because I had to rework the setup of the lido-sdk, which is used for transactions.
Update
reef-knot was updated to 2.1.0, which includes these changes: lidofinance/reef-knot#123
Resolves SI-1298 : maticmum(polygon mumbai test network) was hidden.
Changed the code of wallet disconnect functions, minor update of the autoconnection logic. No changes visible for users.
Added some methods, needed for @Jeday
Checklist: