Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPFS manifest subpath #261

Merged
merged 20 commits into from
Mar 13, 2024
Merged

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Mar 1, 2024

Description

  • Reworks IPFS.json manifest to support different chains and incident banner
  • add support for leastSafeVersion
  • when version is deemed not safe or cannot be verified wallet is disconnected and cannot be connected again

Now UI looks up config on github master branch by DEFAULT_CHAIN

{
  "1": {
    "cid": "<MAINNET_CID>",
    "ens": "<ENS domain>"
  },
  "5": {
    "cid": "<GOERLI_CID>"
    "leastSafeVersion": "1.1.1" // will show  safety warning banner if UI version is less
  },
  "17000": {
    "cid": "<HOLESKY_CID>",
    "ens": "<test ENS domain>"
  }
}

Demo

image

When IPFS widget is outdated
image

When IPFS is not verfiable
image

When IPFS version is less than safe, but there is an update available to safe version
image

Testing notes

Tested locally, will be able to test by updating IPFS.json on main branch

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners March 1, 2024 09:52
@preview-stands
Copy link

preview-stands bot commented Mar 1, 2024

Preview stand status

Stand was demolished

DiRaiks
DiRaiks previously approved these changes Mar 1, 2024
@Jeday Jeday changed the base branch from develop to feature/si-1300-update-reef-knot-to-v2-on-eth-stake-widget-wagmi-autoconnect March 11, 2024 14:22
Jeday added 2 commits March 11, 2024 22:45
…get-wagmi-autoconnect' of github.com:lidofinance/ethereum-staking-widget into feature/si-1292-ipfs-goerli-widget
DiRaiks
DiRaiks previously approved these changes Mar 11, 2024
Copy link
Contributor

@DiRaiks DiRaiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Jeday added 5 commits March 12, 2024 13:25
…get-wagmi-autoconnect' of github.com:lidofinance/ethereum-staking-widget into feature/si-1292-ipfs-goerli-widget
Base automatically changed from feature/si-1300-update-reef-knot-to-v2-on-eth-stake-widget-wagmi-autoconnect to develop March 13, 2024 07:00
@jake4take jake4take dismissed DiRaiks’s stale review March 13, 2024 07:00

The base branch was changed.

@itaven itaven merged commit c60f4bf into develop Mar 13, 2024
6 checks passed
@itaven itaven deleted the feature/si-1292-ipfs-goerli-widget branch March 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants