-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IPFS manifest subpath #261
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview stand statusStand was demolished |
DiRaiks
reviewed
Mar 1, 2024
DiRaiks
previously approved these changes
Mar 1, 2024
…get into feature/si-1292-ipfs-goerli-widget
…get into feature/si-1292-ipfs-goerli-widget
…get-wagmi-autoconnect' of github.com:lidofinance/ethereum-staking-widget into feature/si-1292-ipfs-goerli-widget
Jeday
changed the base branch from
develop
to
feature/si-1300-update-reef-knot-to-v2-on-eth-stake-widget-wagmi-autoconnect
March 11, 2024 14:22
DiRaiks
reviewed
Mar 11, 2024
DiRaiks
reviewed
Mar 11, 2024
…get-wagmi-autoconnect' of github.com:lidofinance/ethereum-staking-widget into feature/si-1292-ipfs-goerli-widget
DiRaiks
previously approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…get-wagmi-autoconnect' of github.com:lidofinance/ethereum-staking-widget into feature/si-1292-ipfs-goerli-widget
Base automatically changed from
feature/si-1300-update-reef-knot-to-v2-on-eth-stake-widget-wagmi-autoconnect
to
develop
March 13, 2024 07:00
DiRaiks
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
leastSafeVersion
Now UI looks up config on github master branch by
DEFAULT_CHAIN
Demo
When IPFS widget is outdated
When IPFS is not verfiable
When IPFS version is less than safe, but there is an update available to safe version
Testing notes
Tested locally, will be able to test by updating IPFS.json on
main
branchChecklist: