feat(qa): more accurate check for l2 banners

lidofinance · Jul 24, 2024 · a8fbf22 · a8fbf22
1 parent a7ad507
commit a8fbf22
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/features/stake/stake-form/wallet/wallet.tsx b/features/stake/stake-form/wallet/wallet.tsx
@@ -103,14 +103,14 @@ export const Wallet: WalletComponentType = memo((props) => {
   const { config } = useConfig();
   const { isL2Chain, isDappActive } = useDappStatus();
 
-  // Display L2 banners only for defaultChain=Mainnet
+  // Display L2 banners only if defaultChain=Mainnet
   // Or via QA helpers override
   const showL2Chain = overrideWithQAMockBoolean(
-    isL2Chain && config.defaultChain === CHAINS.Mainnet,
+    config.defaultChain === CHAINS.Mainnet,
     'mock-qa-helpers-show-l2-banners-on-testnet',
   );
 
-  if (showL2Chain) {
+  if (isL2Chain && showL2Chain) {
     return <L2Fallback {...props} />;
   }
 

diff --git a/features/withdrawals/claim/wallet/wallet.tsx b/features/withdrawals/claim/wallet/wallet.tsx
@@ -39,14 +39,14 @@ export const ClaimWallet: WalletComponentType = memo((props) => {
   const { config } = useConfig();
   const { isL2Chain, isDappActive } = useDappStatus();
 
-  // Display L2 banners only for defaultChain=Mainnet
+  // Display L2 banners only if defaultChain=Mainnet
   // Or via QA helpers override
   const showL2Chain = overrideWithQAMockBoolean(
-    isL2Chain && config.defaultChain === CHAINS.Mainnet,
+    config.defaultChain === CHAINS.Mainnet,
     'mock-qa-helpers-show-l2-banners-on-testnet',
   );
 
-  if (showL2Chain) {
+  if (isL2Chain && showL2Chain) {
     return <L2Fallback {...props} />;
   }
 

diff --git a/features/withdrawals/request/wallet/wallet.tsx b/features/withdrawals/request/wallet/wallet.tsx
@@ -43,14 +43,14 @@ export const RequestWallet: WalletComponentType = memo((props) => {
   const { config } = useConfig();
   const { isL2Chain, isDappActive } = useDappStatus();
 
-  // Display L2 banners only for defaultChain=Mainnet
+  // Display L2 banners only if defaultChain=Mainnet
   // Or via QA helpers override
   const showL2Chain = overrideWithQAMockBoolean(
-    isL2Chain && config.defaultChain === CHAINS.Mainnet,
+    config.defaultChain === CHAINS.Mainnet,
     'mock-qa-helpers-show-l2-banners-on-testnet',
   );
 
-  if (showL2Chain) {
+  if (isL2Chain && showL2Chain) {
     return <L2Fallback {...props} />;
   }
 

diff --git a/features/wsteth/shared/wallet/wallet.tsx b/features/wsteth/shared/wallet/wallet.tsx
@@ -120,14 +120,14 @@ export const Wallet: WalletComponentType = memo((props) => {
   const { config } = useConfig();
   const { isL2Chain, isDappActive } = useDappStatus();
 
-  // Display L2 banners only for defaultChain=Mainnet
+  // Display L2 banners only if defaultChain=Mainnet
   // Or via QA helpers override
   const showL2Chain = overrideWithQAMockBoolean(
-    isL2Chain && config.defaultChain === CHAINS.Mainnet,
+    config.defaultChain === CHAINS.Mainnet,
     'mock-qa-helpers-show-l2-banners-on-testnet',
   );
 
-  if (showL2Chain) {
+  if (isL2Chain && showL2Chain) {
     return <L2Fallback {...props} />;
   }