This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
fix: MUST use GENESIS_FORK_VERSION to sign BLSToExecutionChange message. #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyWh1te
force-pushed
the
fix/compute_domain
branch
from
d947ff4 to
6aa89f2
Compare
kadmil
reviewed
Mar 10, 2023
| @@ -36,7 +36,7 @@ func TestGetSigningRoot(t *testing.T) { | |||
| actual := hex.EncodeToString(got[:]) | |||
|
|
|||
| if actual != tt.want { | |||
| t.Errorf("GetSigningRoot() got = %v, want %v", got, tt.want) | |||
| t.Errorf("GetSigningRoot() got = %v, want %v", actual, tt.want) | |||
There was a problem hiding this comment.
It's a test. Just a variable.
actual := hex.EncodeToString(got[:])
kadmil
reviewed
Mar 10, 2023
sergeyWh1te
force-pushed
the
fix/compute_domain
branch
2 times, most recently
from
0f21a30 to
67dbb44
Compare
sergeyWh1te
force-pushed
the
fix/compute_domain
branch
from
d0d0c5d to
3f2e02a
Compare
pr0n00gler
approved these changes
Mar 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support changes in eth consensus-specs.
Description - ethereum/consensus-specs#3206