Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Draft] Simple Delegation: no revert for _canVoteFor in voteForMultiple #37

Closed
wants to merge 4 commits into from
Closed

[Draft] Simple Delegation: no revert for _canVoteFor in voteForMultiple #37

wants to merge 4 commits into from

Conversation

katamarinaki
Copy link

@katamarinaki katamarinaki commented Feb 29, 2024 •
edited
Loading

Changelog

  • Use if instead of revert in _canVoteFor check inside voteForMultiple;
  • revert voteForMultiple if the delegate hasn't managed to vote for anyone from the list.

@katamarinaki katamarinaki changed the title Simple Delegation: no revert for _canVoteFor in voteForMultiple [Draft] Simple Delegation: no revert for _canVoteFor in voteForMultiple Mar 1, 2024
@katamarinaki katamarinaki reopened this Mar 1, 2024
@katamarinaki katamarinaki changed the base branch from master to voting-manager March 1, 2024 12:25
@katamarinaki katamarinaki changed the title [Draft] Simple Delegation: no revert for _canVoteFor in voteForMultiple Simple Delegation: no revert for _canVoteFor in voteForMultiple Mar 1, 2024
@katamarinaki katamarinaki changed the title Simple Delegation: no revert for _canVoteFor in voteForMultiple [Draft] Simple Delegation: no revert for _canVoteFor in voteForMultiple Mar 1, 2024
@katamarinaki
Copy link
Author

Closed in favor of #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@katamarinaki